[PATCH] D51286: [IndVars] Fix usage of SCEVExpander to not mess with SCEVConstant. PR38674
David Greene via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 29 06:39:08 PDT 2018
greened added inline comments.
================
Comment at: test/Transforms/IndVarSimplify/pr38674.ll:103
+; CHECK: return:
+; CHECK-NEXT: ret i32 [[INC11_LCSSA]]
+;
----------------
Is it really necessary to check all of the generated IR like this? Could the test be written to only check the instructions participating in the LCSSA value flow? If so, it would make the test more robust.
https://reviews.llvm.org/D51286
More information about the llvm-commits
mailing list