[PATCH] D51420: [DebugInfo] Have the verifier accept missing linkage name for anything other than subprograms.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: labath, aprantl.
Herald added a subscriber: hiraditya.
JDevlieghere edited the summary of this revision.

According to the standard, for the .debug_names (the "dwarf accelerator tables):

> If a subprogram or inlined subroutine is included, and has a DW_AT_linkage_name attribute, there will be an additional index entry for the linkage name.

For Swift we generate `DW_structure_type`s with a linkage name and the verifier was incorrectly rejecting this. This patch fixes that. The test is the "reduced" debug info of the failing swift test on swift.org. If there's a way to generate a smaller test case I'm very much open to suggestions.


Repository:
  rL LLVM

https://reviews.llvm.org/D51420

Files:
  llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
  llvm/test/tools/llvm-dwarfdump/X86/verify_no_linkage_name.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51420.163070.patch
Type: text/x-patch
Size: 63733 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180829/37ba3b0b/attachment.bin>