[PATCH] D51151: [NFC] Factor out guard utility methods into a separate file

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 03:12:05 PDT 2018


fedor.sergeev accepted this revision.
fedor.sergeev added a comment.
This revision is now accepted and ready to land.

LGTM, assuming that it is mostly the code movement.
I did not spend any effort to verify that code movement did not affect semantics :)



================
Comment at: include/llvm/Transforms/Utils/GuardUtils.h:23
+/// by the condition of guard's first argument. The taken branch then goes to
+/// the block that contains previous \p Guard's successors, and the non-taken
+/// branch goes to a newly-created deopt block that contains a sole call of
----------------
remove "previous" here, it does not add anything and is a bit confusing.


https://reviews.llvm.org/D51151





More information about the llvm-commits mailing list