[PATCH] D51409: [LLD][ELF] - Do not forget to clean synthetic sections pointers before link().
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 29 03:04:12 PDT 2018
grimar added a comment.
In https://reviews.llvm.org/D51409#1217154, @ruiu wrote:
> I'd memset InX to zero it out instead.
But we do not have an instance of `InX` to use `memset`.
> Also, don't you need to clear In as well?
Right. Will you agree to do cleanup for synthetics in `createSyntheticSections`?
We might set them to `nullptr` there for those that are not always created. Also its the place where we know and have `ELFT`.
https://reviews.llvm.org/D51409
More information about the llvm-commits
mailing list