[PATCH] D51408: Fix MIPS N32 triples support

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan added inline comments.


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp:575
                                          const MCTargetOptions &Options) {
-  return new MipsAsmBackend(T, MRI, STI.getTargetTriple(), STI.getCPU(),
-                            Options.ABIName == "n32");
+  bool n32;
+  if (Options.ABIName == "n32")
----------------
In general, this change is good. But it highlights a problem - there is two entities hold ABI info. The first one is Option.ABIName, the second one is getEnvironment. Both options should be consistent. Is it possible to set ABIName to n32 always if getEnvironment is GNUABIN32 and check just ABIName here? 


Repository:
  rL LLVM

https://reviews.llvm.org/D51408