[PATCH] D50634: [RISCV] Add support for local PIC addressing

[Kito Cheng via Phabricator via llvm-commits]

kito-cheng added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:583
+
+  MachineBasicBlock *NewMBB = F->CreateMachineBasicBlock(LLVM_BB);
+  // Tell AsmPrinter that we unconditionally want the symbol of this label be
----------------
I am worry about that will become kind of barrier for local optimizations, such as instruction scheduling and Machine InstCombiner.

Those optimizations are only process one basic block at once, so it might block some optimization opportunity.


https://reviews.llvm.org/D50634