[PATCH] D51400: Always add a .note.GNU-stack section if -r.

Ryan Prichard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 21:04:41 PDT 2018


rprichard added inline comments.


================
Comment at: lld/ELF/SyntheticSections.h:142
+  GnuStackSection()
+      : SyntheticSection(0, llvm::ELF::SHT_PROGBITS, 1, ".note.GNU-stack") {}
+  void writeTo(uint8_t *Buf) override {}
----------------
I think we want to pass SHF_EXECINSTR as the first SyntheticSection param if Config->ZExecstack is set?


https://reviews.llvm.org/D51400





More information about the llvm-commits mailing list