[PATCH] D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC).

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp updated this revision to Diff 162997.
wolfgangp marked 4 inline comments as done.
wolfgangp added a comment.

Addressed review comments:

- refactored getMaxVersion() in DWARFUnit.h to take an optional default argument.
- Removed some code that is a noop for this patch
- Extracting the initial length field of a list table to a local instead of straight into the header data. This aids error recovery when we find an unsupported DWARF64 length field.
- added a missing comment
- corrected one coding guides violation.


https://reviews.llvm.org/D51081

Files:
  include/llvm/DebugInfo/DWARF/DWARFContext.h
  include/llvm/DebugInfo/DWARF/DWARFDebugRangeList.h
  include/llvm/DebugInfo/DWARF/DWARFDebugRnglists.h
  include/llvm/DebugInfo/DWARF/DWARFListTable.h
  include/llvm/DebugInfo/DWARF/DWARFUnit.h
  lib/DebugInfo/DWARF/CMakeLists.txt
  lib/DebugInfo/DWARF/DWARFContext.cpp
  lib/DebugInfo/DWARF/DWARFDebugRangeList.cpp
  lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp
  lib/DebugInfo/DWARF/DWARFDie.cpp
  lib/DebugInfo/DWARF/DWARFListTable.cpp
  lib/DebugInfo/DWARF/DWARFUnit.cpp
  test/DebugInfo/Generic/cu-ranges.ll
  test/DebugInfo/Inputs/gmlt.ll
  test/DebugInfo/X86/dwarfdump-ranges-baseaddr.s
  test/DebugInfo/X86/dwarfdump-ranges-unrelocated.s
  test/DebugInfo/dwarfdump-ranges.test
  test/MC/ARM/dwarf-asm-multiple-sections.s
  tools/dsymutil/DwarfLinker.cpp
  tools/dsymutil/DwarfStreamer.cpp
  tools/dsymutil/DwarfStreamer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51081.162997.patch
Type: text/x-patch
Size: 59949 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180829/807d191e/attachment-0001.bin>