[PATCH] D50807: [Error] Add FileError helper; upgrade StringError behavior

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 13:40:13 PDT 2018


aganea added inline comments.


================
Comment at: include/llvm/Support/Error.h:1143
+  // Prints S and converts to EC
+  StringError(const Twine &S, std::error_code EC = inconvertibleErrorCode());
 
----------------
I've noticed @lhames mentions [[ https://reviews.llvm.org/D49824?id=157382#inline-438037 | here ]] that usage of `inconvertibleErrorCode()` shall be explicit. I'll change that. Please let me know if there's anything else.


Repository:
  rL LLVM

https://reviews.llvm.org/D50807





More information about the llvm-commits mailing list