[PATCH] D49273: [InstCombine] Expand the simplification of pow() into exp2()
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 28 13:33:26 PDT 2018
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D49273#1216402, @evandro wrote:
> In https://reviews.llvm.org/D49273#1216110, @spatel wrote:
>
> > Are there any negative tests where the base is not a power-of-2? If not, please add at least 1 test like that to make sure we're not transforming that.
>
>
> I believe that `@test_simplify1`, `@test_simplify2`, `@test_simplify9`, `@test_simplify10`, `@test_simplify18`, `@test_simplify19` already function as negative tests for this transformation. Yes?
Not sure if most of those actually make it into this function or if they're simplified sooner. I suppose the exp10 case must, so that's fine.
LGTM
https://reviews.llvm.org/D49273
More information about the llvm-commits
mailing list