[PATCH] D51345: AMDGPU: Shrink insts to fold immediates

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 08:40:27 PDT 2018


rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:2577
+
+// Copy MachineOperand with all flags except setting it as implicit.
+static void copyFlagsToImplicitVCC(MachineInstr &MI,
----------------
This comment is misleading, function does not copy a MO.


================
Comment at: lib/Target/AMDGPU/SIShrinkInstructions.cpp:426
+
+#if 0
       MachineInstrBuilder Inst32 =
----------------
Just remove it.


https://reviews.llvm.org/D51345





More information about the llvm-commits mailing list