[PATCH] D51035: [TableGen] CodeGenDAGPatterns::GenerateVariants - basic caching of matching predicates

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 05:52:15 PDT 2018


RKSimon added a comment.

In https://reviews.llvm.org/D51035#1214882, @kparzysz wrote:

> It should be possible to move this loop out of the nest and only have it iterate over the preexisting patterns.  Could you see if that generates different .inc files (it shouldn't)?


Definitely, but to do it properly requires quite a bit of refactoring - the O(N^2) nature of this loop needs addressing properly - I'd prefer to get this initial patch in first please.


Repository:
  rL LLVM

https://reviews.llvm.org/D51035





More information about the llvm-commits mailing list