[PATCH] D51044: [PatternMatch] Use generic One, Two, ThreeOps_match classes (NFC).
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 28 05:34:01 PDT 2018
fhahn marked an inline comment as done.
fhahn added a comment.
Thanks for having a look @lebedev.ri. I somehow missed your comments until now :/
================
Comment at: include/llvm/IR/PatternMatch.h:1031
+struct ThreeOps_match {
+ T0 Op1;
+ T1 Op2;
----------------
lebedev.ri wrote:
> Here and elsewhere in this patch: so do arrays start from `0` or `1`?
Personally I think it is more natural to refer to them as Op1,2,3 instead of Op0,1,2, but given that we have T0,1,2 using Op0,1,2 seems less confusing overall.
https://reviews.llvm.org/D51044
More information about the llvm-commits
mailing list