[PATCH] D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC).
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 28 02:31:33 PDT 2018
JDevlieghere accepted this revision.
JDevlieghere added a comment.
A few nits, but otherwise this LGTM
================
Comment at: include/llvm/DebugInfo/DWARF/DWARFListTable.h:175
StringRef HeaderString;
+ ///
+ std::function<StringRef(unsigned)> EncodingString;
----------------
Spurious `///` or missing comment?
================
Comment at: include/llvm/DebugInfo/DWARF/DWARFListTable.h:305
+ uint64_t CurrentBase = BaseAddress;
+ for (const auto &Entry : Entries) {
+ Entry.dump(OS, C, AddressSize, CurrentBase, Indent, Version,
----------------
nit: no braces
================
Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:337
+ auto maxVersion = [this](uint16_t DefaultVersion) {
+ uint16_t MaxV = getMaxVersion();
+ return MaxV ? MaxV : DefaultVersion;
----------------
Maybe we can just refactor `getMaxVersion` to take an optional default version?
https://reviews.llvm.org/D51081
More information about the llvm-commits
mailing list