[PATCH] D51280: [CloneFunction] Constant fold terminators before checking single predecessor
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 28 02:22:28 PDT 2018
fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
LGTM thanks!
================
Comment at: test/Transforms/Inline/infinite-loop-two-predecessors.ll:3
+
+define void @f1() {
+bb.0:
----------------
nit: I think the test could be simplified a bit
```
define void @f1() {
bb.0:
br i1 false, label %bb.2, label %bb.1
bb.1: ; preds = %bb.0
br label %bb.2
bb.2: ; preds = %bb.0, %bb.1
%tmp0 = phi i1 [ true, %bb.1 ], [ false, %bb.0 ]
br i1 %tmp0, label %bb.6, label %bb.5
bb.5: ; preds = %bb.5, %bb.5
br i1 undef, label %bb.5, label %bb.5
bb.6: ; preds = %bb.2
ret void
}
```
================
Comment at: test/Transforms/Inline/infinite-loop-two-predecessors.ll:36
+
+; CHECK: define void @f2() {
+; CHECK-NEXT: bb.0:
----------------
CHECK-LABEL?
Repository:
rL LLVM
https://reviews.llvm.org/D51280
More information about the llvm-commits
mailing list