[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added a comment.

I've added a couple of inline comments, but I'm really glad to see this is moving forward and to me this looks very close to smth committable, many thanks for working on this and many thanks for your patience! Please, also address the remaining comments by Jake and James, I really hope we can wrap it up in the nearest future (~days) assuming that the decompression will be implemented in a follow-up patch.



================
Comment at: tools/llvm-objcopy/Object.cpp:170
+void CompressedSection::finalize() {}
+void CompressedSection::accept(SectionVisitor &Visitor) const {
+  Visitor.visit(*this);
----------------
add a blank line between these two methods, please (for better readability)


================
Comment at: tools/llvm-objcopy/Object.h:376
+public:
+  CompressedSection(const SectionBase &Sec,
+                    DebugCompressionType CompressionType)
----------------
since it's quite large - move it to .cpp + initialize as many fields as possible before the ctor body


Repository:
  rL LLVM

https://reviews.llvm.org/D49678