[PATCH] D51330: [ThinLTO] Efficiency fix for writing type id records in per-module indexes
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 27 16:44:49 PDT 2018
tejohnson added inline comments.
================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:744
+ GlobalValue::GUID,
+ TinyPtrVector<const std::pair<const std::string, TypeIdSummary> *>>;
+
----------------
@pcc - do you remember why you used a vector as the map value type? Presumably there should be a 1-1 ratio between the GUIDs computed from type ids and the type id map entry, but is this to handle the potential for GUID conflicts?
Repository:
rL LLVM
https://reviews.llvm.org/D51330
More information about the llvm-commits
mailing list