[llvm] r340732 - [NFC] Try to make buildbot happy about virtual destructors

[David Blaikie via llvm-commits]

Doesn't look like this dtor needs to be virtual - these objects are never
owned/destroyed polymorphically. Instead you could make the base class dtor
protected, and the derived class final. That'd match the usage better I
think.

On Mon, Aug 27, 2018 at 3:10 AM Max Kazantsev via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: mkazantsev
> Date: Mon Aug 27 03:09:28 2018
> New Revision: 340732
>
> URL: http://llvm.org/viewvc/llvm-project?rev=340732&view=rev
> Log:
> [NFC] Try to make buildbot happy about virtual destructors
>
> Modified:
>
> llvm/trunk/include/llvm/Transforms/Utils/InstructionPrecedenceTracking.h
>
> Modified:
> llvm/trunk/include/llvm/Transforms/Utils/InstructionPrecedenceTracking.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Transforms/Utils/InstructionPrecedenceTracking.h?rev=340732&r1=340731&r2=340732&view=diff
>
> ==============================================================================
> ---
> llvm/trunk/include/llvm/Transforms/Utils/InstructionPrecedenceTracking.h
> (original)
> +++
> llvm/trunk/include/llvm/Transforms/Utils/InstructionPrecedenceTracking.h
> Mon Aug 27 03:09:28 2018
> @@ -61,6 +61,8 @@ protected:
>    /// be interested in.
>    virtual bool isSpecialInstruction(const Instruction *Insn) const = 0;
>
> +  virtual ~InstructionPrecedenceTracking() = default;
> +
>  public:
>    /// Clears cached information about this particular block.
>    void invalidateBlock(const BasicBlock *BB);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180827/133f809b/attachment.html>