[PATCH] D51318: [WebAssembly] TableGen backend for stackifying instructions

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 27 14:59:43 PDT 2018


tlively added inline comments.


================
Comment at: utils/TableGen/WebAssemblyStackifierEmitter.cpp:24
+    if (!RecordPair.second->isSubClassOf(InstrClass)) continue;
+    bool IsStackBased = RecordPair.second->getValueAsBit("StackBased");
+    if (IsStackBased) continue;
----------------
aardappel wrote:
> This is going to throw an exception if the field isn't there, but I guess that is ok in this situation?
This is why I check to make sure the Record is a subclass of WebAssemblyInst first.


Repository:
  rL LLVM

https://reviews.llvm.org/D51318





More information about the llvm-commits mailing list