[PATCH] D51317: Keep BumpPtrAllocator::Allocate(0) from returning nullptr

Jordan Rose via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 27 14:16:39 PDT 2018


jordan_rose added a comment.

I'm not sure whether it's better to do this or to remove `LLVM_ATTRIBUTE_RETURNS_NONNULL`. I'll defer to Hans or others on that, since I'm not a frequent LLVM contributor these days.

I will note that it's a little funny to allocate a different `char` for every possible BumpPtrAllocatorImpl instantiation. Maybe that should be moved outside the template?


Repository:
  rL LLVM

https://reviews.llvm.org/D51317





More information about the llvm-commits mailing list