[PATCH] D51307: LoopSink: Don't sink into EH pads (PR38462)

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopSink.cpp:157
+  for (BasicBlock *BB : BBsToSinkInto) {
+    if (BB->isEHPad()) {
+      BBsToSinkInto.clear();
----------------
This will return true for landingpads and cleanuppads, which we can probably sink into just fine. We can limit this to catchswitches, as they are the only blocks that have no insertion point. I guess the most generic way to test would be:
  if (BB->getFirstInsertionPt() == BB->end())


https://reviews.llvm.org/D51307