[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi marked 14 inline comments as done.
plotfi added inline comments.


================
Comment at: tools/llvm-objcopy/llvm-objcopy.cpp:719
+template <typename ELFT>
+static bool handleArgsAndWrite(const CopyConfig &Config, Object &Obj,
+                               const Reader &Reader, Binary &Binary,
----------------
jakehehrlich wrote:
> I kind of like the rough idea of a function that encapsulates the ELFT part of reading and uses it to create the correct writer. This isn't precisely how I think it should work however. This sort of code might let us get rid of ElfType however.
> 
> For now please don't change this. It is not needed for this change.
Cool. Lets discuss something like this for a future patch. At the moment the only purpose of ElfType is to route the ELFT from executeElfObjcopyOnBinary to CreateWriter. 


Repository:
  rL LLVM

https://reviews.llvm.org/D49678