[PATCH] D51247: Support for remapping profile data, for instrumentation-based profiling.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 27 11:24:44 PDT 2018


davidxl added inline comments.


================
Comment at: lib/ProfileData/InstrProfReader.cpp:606
+template<typename HashTableImpl>
+class llvm::InstrProfReaderItaniumRemapper : public InstrProfReaderIndexBase {
+public:
----------------
I suggest moving this remapping support code out of the ProfData core library into llvm-profdata.cpp where an user option (for llvm_profdata) is provided so that the profile data with old naming schemes can be converted to new format:

something like:

llvm_profdata merge -o <new_format_prof_data> -remapping_file=<>   <old_profile_data>


By so doing, compiler does not need to be made aware of it. 


Repository:
  rL LLVM

https://reviews.llvm.org/D51247





More information about the llvm-commits mailing list