[PATCH] D51248: Support for remapping profile data, for sample-based profiling.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: include/llvm/ProfileData/SampleProfReader.h:518
 
+class SampleProfileReaderItaniumRemapper : public SampleProfileReader {
+public:
----------------
Can add some documentation on the class.

Also why put Itanium in the class name? The user provided remapping file should be independent of any C++ ABIs.


================
Comment at: lib/ProfileData/SampleProfReader.cpp:833
+  // we don't know what the original function names were.
+  if (getFormat() == SPF_Compact_Binary) {
+    Ctx.diagnose(DiagnosticInfoSampleProfile(
----------------
Ideally, there should be a tool to convert the compact format file into a non-compact file. The nocompat file is then fed into the profile remapping tool which converts the profile to the remapped namespace.


Repository:
  rL LLVM

https://reviews.llvm.org/D51248