[PATCH] D51122: [PowerPC][MC] Support expressions in getMemRIX16Encoding

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 27 07:52:25 PDT 2018


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

Other than the minor nit about the test case, this LGTM.



================
Comment at: test/MC/PowerPC/ppc64-dq-expr.s:1
+# RUN: llvm-mc -triple powerpc64le-unknown-linux-gnu %s -filetype=obj -o - | \
+# RUN:    llvm-objdump -D  -r - | FileCheck %s
----------------
This may be silly as I'm not familiar with similar tests, but won't you require the `-f` option to force the binary output to `stdout`?


Repository:
  rL LLVM

https://reviews.llvm.org/D51122





More information about the llvm-commits mailing list