[PATCH] D51282: Disable calls to *_finite and other glibc-only functions on Musl.
Rich Felker via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 27 06:39:25 PDT 2018
dalias added a comment.
I'm reasonably happy as long as this is fixed, but I would really rather see the logic reversed: rather than special casing each !glibc, all of these nonstandard functions should be enabled only if(T.isGlibc) to begin with.
You can also possibly remove the exception for musl in the logic for marking the *64() functions unavailable. In musl these are just compat symbols and generating references to them is purely-worse behavior. When _LARGEFILE_SOURCE is defined musl's headers redirect them all at the preprocessor level anyway.
Repository:
rL LLVM
https://reviews.llvm.org/D51282
More information about the llvm-commits
mailing list