[PATCH] D51237: DAG: Check transformed type for forming fminnum/fmaxnum from vselect

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

Nice catch. One suggestion for improvement, apart from that LGTM.



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:7052
 
+  EVT LegalVT = TLI.getTypeToTransformTo(*DAG.getContext(), VT);
   switch (CC) {
----------------
Maybe rename to TargetVT or TransformedVT? After all, this VT isn't necessarily legal...


https://reviews.llvm.org/D51237