[PATCH] D50917: [LLD] [COFF] Support MinGW automatic dllimport of data

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

Thank you for doing this. It looks much less intrusive than I originally thought. Also, thank you for all your code comments. I believe it the new code is easy to understand.



================
Comment at: COFF/Writer.cpp:1152
+void Writer::createRuntimePseudoRelocs() {
+  std::vector<RuntimePseudoReloc> RuntimePseudoRelocs;
+
----------------
Since the scope of this variable is much narrower than before, I'd use a  shorter name, such as Rels.


https://reviews.llvm.org/D50917