[PATCH] D50917: [LLD] [COFF] Support MinGW automatic dllimport of data

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Writer.cpp:191
   bool SetNoSEHCharacteristic = false;
+  std::vector<RuntimePseudoReloc> RuntimePseudoRelocs;
 
----------------
mstorsjo wrote:
> ruiu wrote:
> > Looks like this variable is used only by one function. Can this be a local variable?
> Not really, the `PseudoRelocTableChunk` contains an `ArrayRef` to this, so it needs to be kept alive until the chunks actually are written.
Then maybe you can transfer the ownership of the object?


https://reviews.llvm.org/D50917