[PATCH] D51246: Common infrastructure for reading a profile remapping file and building a mangling remapper from it.

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: include/llvm/ProfileData/ProfRemappingReader.h:103
+  /// data key. The result will be Key() if the name cannot be remapped.
+  Key remap(StringRef FunctionName) {
+    return Canonicalizer.canonicalize(FunctionName);
----------------
It is unclear what semantic this method has from the comments: why do we need to map function name in profile data to profile data key? should they be the same?  The lookup method, on the other hand, is very clear.


Repository:
  rL LLVM

https://reviews.llvm.org/D51246