[PATCH] D50658: Hot cold splitting pass

[Sebastian Pop via Phabricator via llvm-commits]

sebpop added inline comments.


================
Comment at: lib/Transforms/IPO/HotColdSplitting.cpp:294
+        Region.clear();
+        if (ExitColdRegion) {
+          ++NumColdSESEFound;
----------------
In the patch that I posted this if condition was outside the while loop. 

Please move this check outside the while loop body, otherwise you won't iterate the while loop to discover a larger cold region than the first one that we discover with `(*PDT)[BB]->getIDom()->getBlock()`.



https://reviews.llvm.org/D50658