[PATCH] D50998: [LLD] [COFF] Check the instructions in ARM MOV32T relocations

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 24 13:30:08 PDT 2018


mstorsjo added a comment.

Does @efriedma have any opinion about this one? It's slightly unconventional to check the instruction contents in the linker, but OTOH it's at least a simple and safe place to check that nothing really did break these pairs. Unless there's some easy way to add a check in LLVM (and I guess the correct solution there is to keep them together as a pseudo instruction longer, as suggested in the other review), do you think this would be worthwhile?


https://reviews.llvm.org/D50998





More information about the llvm-commits mailing list