aprantl added a comment. @vleschuk, It looks like you *still* haven't addressed my comment > lgtm with the two parameters moved from DIDumpOptions into explict arguments of dumpAddrSection. Can you please get this done ASAP? https://reviews.llvm.org/D49676