[PATCH] D49851: [clang-tidy] run-clang-tidy add synchronisation to the output

Andi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 24 08:31:58 PDT 2018


Abpostelnicu added a comment.

In https://reviews.llvm.org/D49851#1203676, @JonasToth wrote:

> In https://reviews.llvm.org/D49851#1202764, @Abpostelnicu wrote:
>
> > Strangely I haven't had those kind of issues but since you propose those modifications I would do one more modification, let's output everything to stdout and not stderr by doing:
> >
> >   if err:
> >     sys.stdout.write(str(err) + '\n')
> >   
>
>
> You can make this a new revision, fixing the `byte` and `str` issues would be more important now.
>
> The `byte` and `str` thingie is since the whole python3 releases or did it change?


I'm not sure this is the fix for this, I think we should specify the encoding type when building the string from the byte like:

  if err:
    sys.stdout.write(str(err, 'utf-8') + '\n')
   

And of course this must be done only on python 3+ since on python 2 the str ctor doesn't accept the encoding parameter.


Repository:
  rL LLVM

https://reviews.llvm.org/D49851





More information about the llvm-commits mailing list