[PATCH] D50894: Pull google/benchmark library to the LLVM tree

[Kirill Bobyrev via Phabricator via llvm-commits]

kbobyrev added inline comments.


================
Comment at: llvm/CMakeLists.txt:496
 
+option(LLVM_BUILD_BENCHMARKS "Add LLVM benchmark targets to the list of default\
+targets. If OFF, benchmarks still could be built using Benchmarks target." OFF)
----------------
lebedev.ri wrote:
> lebedev.ri wrote:
> > Does stringsplit actually works that way in cmake? I usually did  "sti" newline "ng".
> (It was marked as done without a change, or a comment.)
Ah, sorry, there was a misunderstanding then. I thought what you meant is that the continuation with `\` doesn't append space and I should manually do that.

I think, both work: https://cmake.org/cmake/help/v3.0/manual/cmake-language.7.html#quoted-argument

Your variant seems to be more straightforward, though.


https://reviews.llvm.org/D50894