[PATCH] D50894: Pull google/benchmark library to the LLVM tree

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.

LG other than those last nits.



================
Comment at: llvm/CMakeLists.txt:496
 
+option(LLVM_BUILD_BENCHMARKS "Add LLVM benchmark targets to the list of default\
+targets. If OFF, benchmarks still could be built using Benchmarks target." OFF)
----------------
lebedev.ri wrote:
> Does stringsplit actually works that way in cmake? I usually did  "sti" newline "ng".
(It was marked as done without a change, or a comment.)


================
Comment at: llvm/utils/benchmark/README.LLVM:4-5
+
+This directory contains the Google Benchmark source code with slight CMake
+script modifications. This directory is under a different license than LLVM.
----------------
Ah nice. Somehow i have seen it before, but then forgot.
`slight CMake script modifications` part worries me.
Either those changes need to be documented here, or (best) there shouldn't be any changes,
since you can toggle them via `set()` natively.


https://reviews.llvm.org/D50894