[PATCH] D51127: [ORC] Lock SearchOrder independently from SessionLock to avoid deadlock when resolving relocations.

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz abandoned this revision.
sgraenitz added a comment.

> The title mentioned a deadlock. Did you encounter one, or was this a pre-emptive attempt to reduce lock contention?

Yes first I did, but using the multithreaded version of the SimpleCompiler fixed that. Lock contention was just a side-effect I thought about.

> The error approach I have taken so far is that potentially fatal operations should be as transactional as possible.

Very reasonable.

> I expect that clients will only look up one symbol, the entry point, and call that, so they would not benefit from this.

Ok it's probably the main use case, but I think the ThinLTOLayer would already do parallel lookup. Will investigate next week.

> I have actually been talking to people about removing ErrorList. :)

Nooooooo. Will send you a separate mail for this..


Repository:
  rL LLVM

https://reviews.llvm.org/D51127