[PATCH] D50894: Pull google/benchmark library to the LLVM tree

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Should an `llvm/utils/benchmark/README.LLVM` be added, like `llvm/utils/unittest/googletest/README.LLVM` ?



================
Comment at: llvm/utils/benchmark/CMakeLists.txt:15
+
+option(BENCHMARK_ENABLE_TESTING "Enable testing of the benchmark library." OFF)
+option(BENCHMARK_ENABLE_EXCEPTIONS "Enable the use of exceptions in the benchmark library." OFF)
----------------
There is a very high chance these changes will be lost during drop-in updates.
It may be best to `set()` them in `llvm/CMakeLists.txt`


https://reviews.llvm.org/D50894