[PATCH] D50894: Pull google/benchmark library to the LLVM tree

[Kirill Bobyrev via Phabricator via llvm-commits]

kbobyrev added a comment.

In https://reviews.llvm.org/D50894#1212052, @lebedev.ri wrote:

> Those cmake options still look wrong to me.
>  It looks as-if you are trying to make these two options two three different things, with inconsistent mapping.


Could you please rephrase? I'm not sure I get the last sentence.

Also, sorry, I was is completely wrong. I added your description but both descriptions weren't what the proposed CMake variables do.

`LLVM_INCLUDE_BENCHMARKS` doesn't execute them after the build, just like `LLVM_INCLUDE_TESTS` doesn't execute tests, it simply determines whether build targets would be generated or not (i.e. whether `benchmarks` and `unittests` will be added via `add_subdirectory`).


https://reviews.llvm.org/D50894