[PATCH] D50166: [ARM64] [Windows] MCLayer support for exception handling
Sanjin Sijaric via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 23 18:30:19 PDT 2018
ssijaric added a comment.
I also moved the AArch64 specific changes to the Windows exception handling tables to this patch, as they are needed to get the test case to pass (they are required in order to populate .xdata correctly). The test case also has a dependence on https://reviews.llvm.org/D51201, which adds HasWinCFI to the MIRParser.
There's also a dependence on making MachineFunction::HasWinCFI just a plain bool defaulting to false, instead of Optional<bool>. Otherwise, some existing Windows test cases will fail due to not having HasWinCFI set which is checked during .xdata generation. Reid, can you please submit this change as you mentioned it in https://reviews.llvm.org/D50288? Alternatively, I can go through the failing test cases (about 10 in total) and mark the functions with the "nounwind" attribute.
Repository:
rL LLVM
https://reviews.llvm.org/D50166
More information about the llvm-commits
mailing list