[PATCH] D51173: Fix the configuration of the Primary allocator for Darwin ARM64

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 23 10:21:45 PDT 2018


cryptoad accepted this revision.
cryptoad added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.
Additional question but that doesn't require changes to the CL: if you have a ByteMap it means you are using the SizeClassAllocator32 in 64-bit mode (it's gated by a define, look for SANITIZER_CAN_USE_ALLOCATOR64).
Have you tried using the SizeClassAllocator64?



================
Comment at: lib/sanitizer_common/sanitizer_platform.h:238
 #elif defined(__aarch64__)
-# define SANITIZER_MMAP_RANGE_SIZE FIRST_32_SECOND_64(1ULL << 32, 1ULL << 48)
+#  if SANITIZER_MAC
+// Darwin iOS/ARM64 has a 36-bit VMA, 64GiB VM
----------------
nit: use 1 space for define indentation to conform with the rest of the file.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51173





More information about the llvm-commits mailing list