[PATCH] D51126: [ORC] Lock mutex in IRCompileLayer2::emit() to avoid calling into PassManager::run() in parallel.

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

Hi Stefan,

We actually want the compiler call to be able to proceed on multiple threads concurrently. I think we need a documentation fix here: It just isn't safe to use SimpleCompiler when you're running on multiple threads. You need to use MultiThreadedSimpleCompiler (also in include/llvm/ExecutionEngine/Orc/CompileUtils.h) instead.

Maybe it would be safer to name the multi-threaded variant "SimpleCompiler", and rename the current SimpleCompiler to SingleThreadedSimpleCompiler.

Cheers,
Lang.


Repository:
  rL LLVM

https://reviews.llvm.org/D51126