[PATCH] D51133: win: Omit ".exe" from lld warning and error messages.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/Common/Args.cpp:69
+
+StringRef lld::args::FilenameWithoutExe(StringRef path) {
+  if (sys::path::extension(path).equals_lower(".exe"))
----------------
ruiu wrote:
> path -> Path
Should not function name start from the lower case? I would also add `get` prefix: `getFilenameWithoutExe`.
This would be consistent with other functions around at least.




https://reviews.llvm.org/D51133