[PATCH] D50614: DAG: Allow matching fminnum/fmaxnum from vselect

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 23 00:07:09 PDT 2018


arsenm added a comment.

In https://reviews.llvm.org/D50614#1207687, @spatel wrote:

> Adding more potential reviewers.
>  I don't know how to read AMDGPU output. Is it possible to expose the difference on x86 or AArch64? Or use MIR tests, so we're just seeing the expected DAG node names?


MIR tests don't work for the DAG. The important part is emitting v_pk_max_f16 for the v2f16/v4f16 for the GFX9-NNAN cases. I need to look into why this still doesn't work as expected for the v8f16 case


https://reviews.llvm.org/D50614





More information about the llvm-commits mailing list