[PATCH] D44429: [BinaryFormat] MessagePack reader/writer

[via llvm-commits]

Thanks for the heads up; the fix is in r340507, and the last run of the 
sanitizer build-bot seems to like it.

Scott

On 2018-08-22 23:48, David Blaikie wrote:
> On Wed, Aug 22, 2018 at 7:05 PM via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> 
>> Thank you both! I will try to keep modules in mind in the future.
> 
> You might've missed it in the other replies, but there was an ubsan
> failure in the code too - please take a look at that :)
> 
> - Dave
> 
>> Scott
>> 
>> On 2018-08-22 22:02, David Blaikie via Phabricator wrote:
>>> dblaikie added a comment.
>>> 
>>> In https://reviews.llvm.org/D44429#1210470 [1], @kristina wrote:
>>> 
>>>> Don't have commit access but this should be revised to update the
>> 
>>>> modulemap.
>>>> 
>>>> module LLVM_BinaryFormat {
>>>> requires cplusplus
>>>> umbrella "BinaryFormat" module * { export * }
>>>> textual header "BinaryFormat/Dwarf.def"
>>>> // -snip-
>>>> textual header "BinaryFormat/WasmRelocs.def"
>>>> textual header "BinaryFormat/MsgPack.def"
>>>> }
>>>> 
>>>> 
>>>> Modular build passes after that.
>>> 
>>> 
>>> Ah, no worries - committed in r340506 - thanks!
>>> 
>>> 
>>> Repository:
>>> rL LLVM
>>> 
>>> https://reviews.llvm.org/D44429 [2]
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits [3]
> 
> 
> Links:
> ------
> [1] https://reviews.llvm.org/D44429#1210470
> [2] https://reviews.llvm.org/D44429
> [3] http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits