[PATCH] D44429: [BinaryFormat] MessagePack reader/writer

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 19:12:58 PDT 2018


kristina accepted this revision.
kristina added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D44429#1210484, @dblaikie wrote:

> In https://reviews.llvm.org/D44429#1210470, @kristina wrote:
>
> > Don't have commit access but this should be revised to update the modulemap.
> >
> >   module LLVM_BinaryFormat {
> >       requires cplusplus
> >       umbrella "BinaryFormat" module * { export * }
> >       textual header "BinaryFormat/Dwarf.def"
> >       // -snip-
> >       textual header "BinaryFormat/WasmRelocs.def"
> >       textual header "BinaryFormat/MsgPack.def"
> >   }
> >
> >
> > Modular build passes after that.
>
>
> Ah, no worries - committed in r340506 - thanks!


Thank you! Buildbot for next one (numbering is odd, I know, `/o/org.llvm.caches/llvm-8.0/4080`) passed.


Repository:
  rL LLVM

https://reviews.llvm.org/D44429





More information about the llvm-commits mailing list