[PATCH] D51133: win: Omit ".exe" from lld warning and error messages.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 22 16:32:59 PDT 2018
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lld/Common/Args.cpp:69
+
+StringRef lld::args::FilenameWithoutExe(StringRef path) {
+ if (sys::path::extension(path).equals_lower(".exe"))
----------------
path -> Path
================
Comment at: lld/Common/Args.cpp:70
+StringRef lld::args::FilenameWithoutExe(StringRef path) {
+ if (sys::path::extension(path).equals_lower(".exe"))
+ return sys::path::stem(path);
----------------
This can be `Path.endswith_lower(".exe")`.
https://reviews.llvm.org/D51133
More information about the llvm-commits
mailing list