[PATCH] D50277: [WebAssembly] Support for atomic fences

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 22 16:00:17 PDT 2018


aheejin added a comment.

We discussed how to implement fences here <https://github.com/WebAssembly/tool-conventions/issues/59>, and I think the general consensus was even though it may not be strictly necessary to emit `atomicrmw` for some cases, it can be user friendly and also might help support legacy builtins like `__sync_synchronize()`. And IMHO it is a single instruction anyway and fences are generally expected to be expensive, so no significant harm will be done. Does anyone have more concerns on this? If not, can we land this?


Repository:
  rL LLVM

https://reviews.llvm.org/D50277





More information about the llvm-commits mailing list