[PATCH] D51133: win: Omit ".exe" from lld warning and error messages.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

It looks like this patch uses the knowledge of the default filename of the lld executable for each target, but what we want to do is simple: strip ".exe" from the end of the string if exists. So maybe we should create stripExe function or something?



================
Comment at: lld/ELF/Driver.cpp:77
                raw_ostream &Error) {
-  errorHandler().LogName = sys::path::filename(Args[0]);
+  if (sys::path::extension(Args[0]) == ".exe")
+    errorHandler().LogName = sys::path::stem(Args[0]);
----------------
I believe you need case-insensitive comparison.


https://reviews.llvm.org/D51133