[PATCH] D51082: [WebAssembly] Arbitrary BUILD_VECTOR and remove i64x2.mul

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:128
+  if (Subtarget->hasSIMD128() && EnableUnimplementedWasmSIMDInstrs)
+    setOperationAction(ISD::MUL, MVT::v2i64, Expand);
+
----------------
What happens if `hasSIMD128() == true` but not `EnableUnimplementedWasmSIMDInstrs`?


================
Comment at: test/CodeGen/WebAssembly/simd.ll:110
+                             i8 %x8, i8 %x9, i8 %x10, i8 %x11,
+                             i8 %x12, i8 %x13, i8 %x14, i8 %x15) {
+  %t0 = insertelement <16 x i8> undef, i8 %x0, i32 0
----------------
Fix indentation of these three lines so they align with the first line


Repository:
  rL LLVM

https://reviews.llvm.org/D51082